Multiple openapi @dataExamples#224
Conversation
| @@ -1,699 +1,711 @@ | |||
| { | |||
There was a problem hiding this comment.
This is unfortunate that this change is counted like that in git. VSCode is doing a better job visualizing the differences, by hiding unrelevant lines
|
|
kubukoz
left a comment
kubukoz
left a comment
There was a problem hiding this comment.
mostly lgtm, just some nitpicks
now that I'm looking at this up close, that doesn't seem right. It makes it seem Examples is a field... from what I can see editor.swagger.io doesn't support OpenAPI 3.1: 
The "old" example looks fine: 
but with multiples, the best I can get is the same you got: 
It seems confusing / misleading on Swagger UI's side :/ |
|
Raised issue swagger-api/swagger-ui#10503 |
|
I assume Swagger will take its while to acknowledge and/or implement this. For now, let's hide it behind a configuration option (in addition to the OpenAPI 3.1 gate we already have) and move on |
We don't control |
|
I hoped there was a mechanism to put arbitrary properties in it :( contribution idea for smithy-openapi? |
Related smithy PR smithy-lang/smithy#2705 |
|
okay... what happened here? 
I don't see it locally. Maybe the runner state got corrupted... let me reopen in a fresh branch to purge it |
|
not my proudest moment... I only today realized we were behind main, that's why it passed locally... 🤦 |
kubukoz
force-pushed
the
multiple-data-examples
branch
from
5404f05 to
d8fd9cf
Compare
4 participants
This is how it looks like after the change